Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached local representatives list #1372

merged 40 commits into from Jan 30, 2019


6 participants
Copy link

commented Nov 9, 2018

with vote_minimum for config.json to prevent accidental multiple account voting for large services

clemahieu and others added some commits Oct 9, 2018

Representative weight drifts slowly on the active network. foreach_re…
…presentative is called frequently and in the voting loop. Instead of doing a linear scan of the wallet and an IO checking for the weight of each account, periodically recompute if there are representative keys in any of the wallets.
Simplify logic in main code paths by removing if-checks on if voting …
…is enabled and do it inside foreach_representative.
Add config option for minimum local representative weight
Default 1000 Nano
Large services can set higher values to limit votes CPU load, while singe users willing to have small working representative can set it lower

@rkeene rkeene added the enhancement label Nov 14, 2018

@rkeene rkeene added this to the V18.0 milestone Nov 14, 2018

@zhyatt zhyatt added this to Unscheduled in V18 Dec 27, 2018

SergiySW added some commits Dec 28, 2018

@SergiySW SergiySW moved this from Unscheduled to CP 0 in V18 Dec 28, 2018

SergiySW added some commits Dec 28, 2018

@zhyatt zhyatt requested review from clemahieu and rkeene and removed request for clemahieu Dec 31, 2018

@SergiySW SergiySW changed the title Cached representatives Cached local representatives Jan 24, 2019

@SergiySW SergiySW changed the title Cached local representatives Cached local representatives list Jan 26, 2019

@zhyatt zhyatt requested a review from clemahieu Jan 29, 2019


rkeene approved these changes Jan 29, 2019

@zhyatt zhyatt requested review from cryptocode and wezrule and removed request for clemahieu and cryptocode Jan 30, 2019

Copy link

left a comment

LGTM (it was discussed to append the v16_values test)

@zhyatt zhyatt merged commit aa3ac69 into nanocurrency:master Jan 30, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.