Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only observe blocks if callback is configured #1375

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
2 participants
@cryptocode
Copy link
Collaborator

commented Nov 12, 2018

To avoid unnecessary background() calls, as well as to reduce the amount of block_arrival.recent invocations.

block_arrival.recent is called from process_receive_one as well, so not calling it from the observer should still get the arrival.erase logic done.

@rkeene

rkeene approved these changes Nov 14, 2018

Copy link
Contributor

left a comment

Thanks !

@rkeene rkeene added the enhancement label Nov 14, 2018

@rkeene rkeene added this to the V17.0 milestone Nov 14, 2018

@rkeene rkeene merged commit f9cf204 into nanocurrency:master Nov 14, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:callback-opt branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.