Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secure rpc build #1404

Merged
merged 1 commit into from Nov 21, 2018

Conversation

Projects
None yet
3 participants
@cryptocode
Copy link
Collaborator

commented Nov 21, 2018

The cmake restructuring removed the linker reference.

@PlasmaPower

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2018

Shouldn't the add_library (${OPENSSL_LIBRARIES}) be in the if (RAIBLOCKS_SECURE_RPC) section above?

@cryptocode

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 21, 2018

${OPENSSL_LIBRARIES} is added to target_link_libraries- it's blank if building without secure rpc.

@PlasmaPower
Copy link
Contributor

left a comment

Makes sense

@rkeene rkeene added this to the V17.0 milestone Nov 21, 2018

@rkeene rkeene merged commit ac4c640 into nanocurrency:master Nov 21, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

rkeene added a commit that referenced this pull request Nov 21, 2018

@cryptocode cryptocode deleted the cryptocode:securerpc-buildfix branch Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.