Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend "bulk_pull" to have a count parameter #1432

Merged
merged 13 commits into from Dec 8, 2018

Conversation

Projects
None yet
2 participants
@rkeene
Copy link
Contributor

commented Dec 7, 2018

Fixes #1431

@rkeene rkeene added this to the V17.0 milestone Dec 7, 2018

@rkeene rkeene self-assigned this Dec 7, 2018

rkeene added some commits Dec 7, 2018

We need to be able to determine the extended size from the header alone
We need to be able to determine the extended size from the header alone,
support getting the flag and pulling that information from the header
but a better way may be to have a message_header method that supplies
this information for each type of block, based on the header

@rkeene rkeene removed the incomplete label Dec 7, 2018

@rkeene rkeene requested a review from cryptocode Dec 7, 2018

@rkeene rkeene merged commit 152bc57 into nanocurrency:master Dec 8, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

rkeene added a commit that referenced this pull request Dec 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.