Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Confirmation History #1433

Merged
merged 1 commit into from Dec 8, 2018

Conversation

Projects
None yet
3 participants
@argakiig
Copy link
Collaborator

commented Dec 7, 2018

to include confirmation time per block and Avg
example response

    "confirmation_stats": {
        "count": "18",
        "average": "18.657268277833328"
    },
    "confirmations": [
        {
            "hash": "862AB923DA184D85D5719D8222463E6DA6D6DB33F026B079B5F628C0598C4645",
            "duration": "7.6989772170000004",
            "tally": "67004984199081277794346622015067693764"
        },

...

@rkeene rkeene added this to the V18.0 milestone Dec 7, 2018

@rkeene rkeene added the enhancement label Dec 7, 2018

@rkeene rkeene modified the milestones: V18.0, V17.0 Dec 7, 2018

@rkeene rkeene added the incomplete label Dec 8, 2018

Show resolved Hide resolved rai/node/rpc.cpp Outdated
Show resolved Hide resolved rai/node/rpc.cpp Outdated
Show resolved Hide resolved rai/node/rpc.cpp Outdated

@rkeene rkeene removed the incomplete label Dec 8, 2018

@rkeene

rkeene approved these changes Dec 8, 2018

@argakiig argakiig force-pushed the argakiig:history_avg branch from c6bea63 to f37c1fe Dec 8, 2018

add confirmation stats and per block duration to confirmation_history
```
 "confirmation_stats": {
        "count": "18",
        "average": "18.657268277833328"
    },
    "confirmations": [
        {
            "hash": "862AB923DA184D85D5719D8222463E6DA6D6DB33F026B079B5F628C0598C4645",
            "duration": "7.6989772170000004",
            "tally": "67004984199081277794346622015067693764"
        },
```

@argakiig argakiig force-pushed the argakiig:history_avg branch from f37c1fe to 7b2205b Dec 8, 2018

@rkeene rkeene merged commit 1ac017d into nanocurrency:releases/v17 Dec 8, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

rkeene added a commit that referenced this pull request Dec 8, 2018

@argakiig argakiig deleted the argakiig:history_avg branch Dec 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.