Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close sockets gracefully #1445

Merged

Conversation

Projects
3 participants
@cryptocode
Copy link
Collaborator

commented Dec 13, 2018

The docs recommend shutdown before close [1] and most asio servers I've seen do this (the IPC patch does the same). Should evict pending io ops immediately/flush buffers properly on all platforms before closing.

[1] https://www.boost.org/doc/libs/1_66_0/doc/html/boost_asio/reference/basic_stream_socket/close/overload2.html

@cryptocode cryptocode force-pushed the cryptocode:improvement/graceful-socket-shutdown branch from de44c8d to 80fea28 Dec 13, 2018

@argakiig argakiig self-requested a review Dec 13, 2018

@rkeene rkeene added this to the V18.0 milestone Dec 13, 2018

@rkeene rkeene merged commit 15c95a3 into nanocurrency:master Dec 14, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zhyatt zhyatt added this to Unscheduled in V18 Dec 27, 2018

@cryptocode cryptocode moved this from Unscheduled to CP 1 (2018-01-09) in V18 Dec 28, 2018

@cryptocode cryptocode moved this from CP 1 (2018-01-09) to CP 0 in V18 Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.