Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume future outside of client scope #1466

Merged
merged 2 commits into from Dec 16, 2018

Conversation

Projects
None yet
3 participants
@clemahieu
Copy link
Collaborator

commented Dec 16, 2018

No description provided.

Consume future outside of client scope otherwise in case of network e…
…rror, there will still be a remaining reference to bulk_push_client and the future will not exception terminate.

@clemahieu clemahieu requested a review from SergiySW Dec 16, 2018

@SergiySW SergiySW added this to the V17.0 milestone Dec 16, 2018

@SergiySW
Copy link
Collaborator

left a comment

This should close issue with stuck bulk_push_client after error

Show resolved Hide resolved rai/node/bootstrap.cpp Outdated

@rkeene rkeene added the bug label Dec 16, 2018

@rkeene rkeene merged commit d46621d into master Dec 16, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@clemahieu clemahieu deleted the bulk_push_scoping branch Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.