Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dupsort from unchecked table #1483

Merged
merged 5 commits into from Dec 19, 2018

Conversation

Projects
3 participants
@SergiySW
Copy link
Collaborator

commented Dec 18, 2018

Currently without upgrade path (clear unchecked before or after using patch)

Part of work on #1478

Remove dupsort from unchecked table
Currently without upgrade path (clear unchecked before or after using patch)

@SergiySW SergiySW self-assigned this Dec 18, 2018

@SergiySW SergiySW requested a review from cryptocode Dec 18, 2018

@rkeene rkeene added this to the V18.0 milestone Dec 18, 2018

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Dec 18, 2018

Works great, significant speedup on my ssd test machine.

@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 18, 2018

Great! Then adding upgrade path

@@ -1770,18 +1770,17 @@ std::shared_ptr<rai::vote> rai::mdb_store::vote_get (rai::transaction const & tr
std::vector<std::shared_ptr<rai::block>> rai::mdb_store::unchecked_get (rai::transaction const & transaction_a, rai::block_hash const & hash_a)

This comment has been minimized.

Copy link
@rkeene

rkeene Dec 18, 2018

Contributor

An unchecked_exists() could also be helpful

This comment has been minimized.

Copy link
@SergiySW

SergiySW Dec 18, 2018

Author Collaborator

unchecked_exists for key hash? Or for unchecked_key (uint256+uint256)?
If by block own hash, then we need extra lookup table

This comment has been minimized.

Copy link
@rkeene

rkeene Dec 18, 2018

Contributor

unchecked_key (successor/alternate and block hash)

@rkeene

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2018

Getting some issue with this on the beta network:

[beta] nano-rpc 17.0> show stats -bootstrap
Blocks:
  Count     = 3116
  Unchecked = 6584909
  Total     = 6588025
[beta] nano-rpc 17.0>

But there are only 5 million blocks on the beta network 😄

@rkeene

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2018

It looks like my issue was that I didn't delete the DB beforehand (and before the upgrade path existed), dupsort=1 is still set

@rkeene rkeene removed the experiment label Dec 19, 2018

@rkeene

rkeene approved these changes Dec 19, 2018

Copy link
Contributor

left a comment

Much faster and looks good !

@rkeene rkeene merged commit 3749ac2 into nanocurrency:master Dec 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zhyatt zhyatt added this to Unscheduled in V18 Dec 27, 2018

@SergiySW SergiySW moved this from Unscheduled to CP 0 in V18 Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.