Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a possible thread stall #1494

Merged
merged 2 commits into from Dec 28, 2018

Conversation

Projects
None yet
3 participants
@clemahieu
Copy link
Collaborator

commented Dec 21, 2018

Fix for #1491

Fix a possible thread stall resulting in processing delay or OS udp b…
…uffer overflow.

Two classes of threads are waiting on a common conditionion variable. Enqueue may notify a thread waiting on allocate or release may notify a thread waiting to dequeue.

Notify all waiting threads to check their conditions.

@rkeene rkeene added this to the V18.0 milestone Dec 21, 2018

@rkeene rkeene added the bug label Dec 21, 2018

@rkeene rkeene self-requested a review Dec 21, 2018

@rkeene

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2018

Tests pass, except for the load tester which has some kind of internal Travis CI error that intermittently happens

@zhyatt zhyatt added this to Unscheduled in V18 Dec 27, 2018

@rkeene

rkeene approved these changes Dec 28, 2018

Copy link
Contributor

left a comment

This will work -- an alternate fix might be to have two condition variables so that we wake up the right set of waiting workers.

@rkeene rkeene merged commit 34926f8 into master Dec 28, 2018

2 of 3 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zhyatt zhyatt moved this from Unscheduled to CP 0 in V18 Jan 4, 2019

@zhyatt zhyatt modified the milestones: V18.0, V17.1 Jan 16, 2019

@zhyatt zhyatt removed this from CP 0 in V18 Jan 16, 2019

rkeene added a commit that referenced this pull request Jan 17, 2019

@clemahieu clemahieu deleted the udp_notify branch Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.