Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test retry #1495

Merged
merged 2 commits into from Dec 21, 2018

Conversation

Projects
2 participants
@rkeene
Copy link
Contributor

commented Dec 21, 2018

Two related changes:

  1. The retry timer we set expired on December 20, 2018 -- before we had a chance to fix all the intermittently failing tests (originally set in #1218)
  2. The bash specification contains a bug where empty arrays are treated as unbound, this works around that

@rkeene rkeene added the bug label Dec 21, 2018

@rkeene rkeene self-assigned this Dec 21, 2018

@rkeene rkeene requested review from icarusglider and argakiig and removed request for icarusglider Dec 21, 2018

@argakiig
Copy link
Collaborator

left a comment

LGTM this will keep tests from being all wonky

@rkeene rkeene added this to the V18.0 milestone Dec 21, 2018

@rkeene rkeene merged commit 3314332 into nanocurrency:master Dec 21, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

rkeene added a commit that referenced this pull request Dec 27, 2018

@zhyatt zhyatt added this to Unscheduled in V18 Dec 27, 2018

@zhyatt zhyatt moved this from Unscheduled to CP 0 in V18 Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.