Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ip_address_hash from std namespace #1499

Conversation

Projects
4 participants
@wezrule
Copy link
Collaborator

commented Dec 23, 2018

In similar vein to #1460 the ip_address_hash struct and specializations have been removed from polluting the std namespace.

@zhyatt zhyatt added this to the V18.0 milestone Dec 27, 2018

@zhyatt zhyatt requested a review from clemahieu Dec 27, 2018

@zhyatt zhyatt added this to Unscheduled in V18 Dec 27, 2018

@rkeene rkeene force-pushed the wezrule:remove_ip_address_hash_from_std_namespace branch from 46eda74 to a2605c0 Dec 28, 2018

@rkeene

This comment has been minimized.

Copy link
Contributor

commented Dec 28, 2018

After merging #1504, I force pushed an update to this branch.

@rkeene rkeene requested review from rkeene and removed request for clemahieu Dec 31, 2018

@rkeene rkeene assigned rkeene and unassigned clemahieu Dec 31, 2018

@rkeene rkeene moved this from Unscheduled to CP 0 in V18 Dec 31, 2018

@rkeene

rkeene approved these changes Jan 3, 2019

Copy link
Contributor

left a comment

Thanks !

@rkeene rkeene removed the incomplete label Jan 3, 2019

@rkeene rkeene merged commit 37222c2 into nanocurrency:master Jan 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:remove_ip_address_hash_from_std_namespace branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.