Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pool_connection () for stopped bootstrap or bootstrap_client #1500

Merged
merged 2 commits into from Dec 29, 2018

Conversation

Projects
None yet
3 participants
@SergiySW
Copy link
Collaborator

commented Dec 26, 2018

Fixes #1496

@SergiySW SergiySW self-assigned this Dec 26, 2018

@zhyatt

This comment has been minimized.

Copy link
Collaborator

commented Dec 27, 2018

@SergiySW Can you find out when this issue first showed up? And also if anything we have done recently has made this worse? Trying to evaluate where to include this fix.

@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 27, 2018

Ptobably it's related to lazy_bootstrap implementation (#1332) especially https://github.com/nanocurrency/raiblocks/blob/master/rai/node/bootstrap.cpp#L594
But it also happening with previous versions or with disabled lazy bootstrap, just less often.
Also bulk_pull_client and pulk_push_server now more often drop connections

@zhyatt zhyatt requested review from clemahieu and rkeene Dec 27, 2018

@zhyatt

This comment has been minimized.

Copy link
Collaborator

commented Dec 27, 2018

Looking at including this in V18 unless there is an urgency to push earlier.

@SergiySW SergiySW added the bug label Dec 27, 2018

@zhyatt zhyatt added this to the V18.0 milestone Dec 28, 2018

@zhyatt zhyatt added this to Unscheduled in V18 Dec 28, 2018

@SergiySW SergiySW moved this from Unscheduled to CP 0 in V18 Dec 28, 2018

@rkeene

rkeene approved these changes Dec 28, 2018

Copy link
Contributor

left a comment

This ensures that we respect the request to stop using a connection and close it as soon as it goes out of scope -- looks good to me !

@SergiySW SergiySW changed the base branch from releases/v17 to master Dec 28, 2018

@SergiySW SergiySW force-pushed the SergiySW:pool_connection branch from 5c903e7 to 13234f9 Dec 28, 2018

@rkeene rkeene merged commit 250ffac into nanocurrency:master Dec 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zhyatt zhyatt modified the milestones: V18.0, V17.1 Jan 16, 2019

@zhyatt zhyatt removed this from CP 0 in V18 Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.