Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build essential boost libraries in docker #1507

Merged
merged 5 commits into from Jan 2, 2019

Conversation

Projects
3 participants
@wezrule
Copy link
Collaborator

commented Dec 28, 2018

In the Dockerfile used for continuous integration all the boost libraries are built; however we only need 4: thread, log, filesystem & program_options. Now this isn't a big issue as we use the option "--cache-from nanocurrency/nano-ci:latest", which picks up the boost files from the intermediate cache layer. But it would be a bit quicker getting the cache and also result in a smaller docker image.

I've made another adjustment as per the docker best practices "Always combine RUN apt-get update with apt-get install in the same RUN statement". This is because, if we only changed the second RUN then we would not be getting the latest repositories from apt even though apt-get update is called in the first one, because it is taken from the cache.

It is also recommend to clear the apt cache with rm -rf /var/lib/apt/lists/* after calling apt-get install, however this caused problems getting ccache from travis-ci, so I have left this as is.

wezrule added some commits Dec 28, 2018

@wezrule wezrule referenced this pull request Dec 28, 2018

Closed

Wiki improvements (mostly boost related) #1508

5 of 5 tasks complete
Show resolved Hide resolved docker/ci/Dockerfile Outdated
@rkeene

rkeene approved these changes Dec 28, 2018

Copy link
Contributor

left a comment

Thanks !

Show resolved Hide resolved docker/ci/Dockerfile Outdated

@zhyatt zhyatt added the documentation label Jan 2, 2019

@zhyatt zhyatt added this to the V18.0 milestone Jan 2, 2019

@rkeene rkeene merged commit aec6a2e into nanocurrency:master Jan 2, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:build_essential_boost_in_docker branch Jan 3, 2019

@zhyatt zhyatt added this to CP 1 (2018-01-09) in V18 Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.