Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable voting by default #1509

Merged
merged 2 commits into from Jan 7, 2019

Conversation

Projects
4 participants
@argakiig
Copy link
Collaborator

commented Dec 28, 2018

... unless user action taken. This will not affect a current config, only newly generated ones
fixes #1369

@argakiig argakiig added this to the V18.0 milestone Dec 28, 2018

@SergiySW

This comment has been minimized.

Copy link
Collaborator

commented Dec 28, 2018

Guess for test_network it should be true

argakiig added some commits Dec 28, 2018

Disable voting by default unless specified otherwise. This will not o…
…verwrite existing settings but will ensure new nodes do not vote unless users specify.

fixes #1369

@argakiig argakiig force-pushed the argakiig:disable_voting branch from 34f9265 to 7034245 Dec 28, 2018

@argakiig argakiig self-assigned this Dec 28, 2018

@rkeene rkeene changed the title Disable voting by default... Disable voting by default Dec 28, 2018

@zhyatt zhyatt added this to Unscheduled in V18 Dec 28, 2018

@argakiig argakiig moved this from Unscheduled to CP 0 in V18 Dec 29, 2018

@argakiig argakiig moved this from CP 0 to CP 1 (2018-01-09) in V18 Dec 29, 2018

@zhyatt zhyatt requested a review from SergiySW Dec 31, 2018

@rkeene rkeene merged commit 3a0dcf7 into nanocurrency:master Jan 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@argakiig argakiig deleted the argakiig:disable_voting branch Jan 16, 2019

@qwahzi

This comment has been minimized.

Copy link

commented Feb 2, 2019

Are there any concerns that "Disable voting by default [#1509]" will reduce decentralization? Will new node operators (merchants, whales, exchanges, etc) know that they need to manually enable voting once they hit .1% voting weight?

Worst case, what if a bunch of node operators clean install a new node version at the same time and forget to enable voting (similar to the issues we had with the v17 upgrade)? Would it make more sense to have the default be no voting unless you have .1%+ voting weight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.