Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests broken with #1510 #1524

Merged
merged 1 commit into from Jan 9, 2019

Conversation

Projects
5 participants
@argakiig
Copy link
Collaborator

commented Dec 31, 2018

Neglected to update tests to match status, fixes tests broken in #1510

@argakiig argakiig self-assigned this Dec 31, 2018

@argakiig argakiig added this to the V18.0 milestone Dec 31, 2018

@argakiig argakiig added this to CP 1 (2018-01-09) in V18 Dec 31, 2018

@argakiig argakiig requested review from cryptocode, rkeene and SergiySW Dec 31, 2018

@argakiig argakiig added the bug label Dec 31, 2018

@argakiig argakiig referenced this pull request Dec 31, 2018

Closed

Split wallet from ledger #1525

0 of 2 tasks complete
@rkeene

This comment has been minimized.

Copy link
Contributor

commented Dec 31, 2018

The Qt tests failed with:

[ RUN      ] wallet.startup_balance
/workspace/nano/qt_test/qt.cpp:74: Failure
Value of: wallet->self.balance_label->text ().toStdString ()
  Actual: ""
Expected: "Balance: 0 NANO"
[  FAILED  ] wallet.startup_balance (44 ms)
[ RUN      ] wallet.select_account
/workspace/nano/qt_test/qt.cpp:96: Failure
Value of: key4
  Actual: 32-byte object <EC-09 BE-40 0D-85 35-B0 F8-AA 7A-E5 87-6E FF-A4 96-94 D8-37 93-70 BC-F1 70-8E D2-9F 83-41 DD-B1>
Expected: key2
Which is: 32-byte object <53-97 54-B7 13-5A 26-9B A5-10 F4-92 6D-C5 E3-05 AC-86 AF-BE DD-18 97-54 01-21 E4-C9 F0-85 45-F8>
[  FAILED  ] wallet.select_account (48 ms)

Is this related, or an intermittently failing test ?

@argakiig

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 31, 2018

I'm not sure.about the first one, thought it started failing in another PR, will look further

the second intermittent, what's happening there is since it uses a random seed, the index 0 may be ordered before or after index 1 when it's generated and so the selection will sometimes not change to the other account and has been around for a.while

@cryptocode cryptocode added the unit test label Jan 2, 2019

@zhyatt zhyatt merged commit 7335442 into nanocurrency:master Jan 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rkeene
Copy link
Contributor

left a comment

Russel said that both failing Qt tests were not supposed to be fixed here.

@argakiig argakiig deleted the argakiig:fix_status branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.