Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"update_existing_accounts" option for RPC wallet_representative_set #1531

Changes from 1 commit
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

Rename option to "update_existing_accounts"

  • Loading branch information...
SergiySW committed Jan 2, 2019
commit 436a361fd0ec2803f681ff3160c767439c0b8125
@@ -580,7 +580,7 @@ TEST (rpc, wallet_representative_set_force)
nano::keypair key;
request.put ("action", "wallet_representative_set");
request.put ("representative", ());
request.put ("force", true);
request.put ("update_existing_accounts", true);
test_response response (request, rpc, system.io_ctx);
system.deadline_set (5s);
while (response.status == 0)
@@ -3491,7 +3491,7 @@ void nano::rpc_handler::wallet_representative_set ()
wallet->store.representative_set (transaction, representative);
// Change representative for all wallet accounts
if (request.get<bool> ("force", false))
if (request.get<bool> ("update_existing_accounts", false))
std::deque<nano::account> accounts;
This conversation was marked as resolved by SergiySW

This comment has been minimized.

Copy link

wezrule Jan 2, 2019


I'm not sure std::deque is the right data structure to use here, it is generally only used when popping from the front is required, I think std::vector should be used.

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.