Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent send_node_id_handshake failure #1532

Conversation

Projects
2 participants
@cryptocode
Copy link
Collaborator

commented Jan 2, 2019

Some tests rely on stats. In this case the node_id_handshake stat was updated before peer insertion, causing the test to fail sporadically.

@cryptocode cryptocode self-assigned this Jan 2, 2019

@cryptocode cryptocode added this to the V18.0 milestone Jan 2, 2019

@cryptocode cryptocode added this to CP 1 (2018-01-09) in V18 Jan 2, 2019

@zhyatt zhyatt requested a review from rkeene Jan 7, 2019

@rkeene

rkeene approved these changes Jan 17, 2019

Copy link
Contributor

left a comment

Thanks !

@rkeene rkeene merged commit 8685c20 into nanocurrency:master Jan 17, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:testfix/intermittent-send_node_id_handshake branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.