Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recursive_mutex to foreach_representative #1533

Merged
merged 1 commit into from Jan 2, 2019
Merged

Add recursive_mutex to foreach_representative #1533

merged 1 commit into from Jan 2, 2019

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Jan 2, 2019

To prevent node.unlock_search assert

Initially part of v17 #1409

@SergiySW
Add recursive_mutex to foreach_representative
f3da5d5 
To prevent node.unlock_search assert

Initially part of v17 nanocurrency#1409
@SergiySW SergiySW added the bug label Jan 2, 2019
@SergiySW SergiySW self-assigned this Jan 2, 2019
@zhyatt zhyatt requested a review from cryptocode January 2, 2019 14:30
@zhyatt zhyatt added this to the V18.0 milestone Jan 2, 2019
@zhyatt zhyatt added this to CP 1 (2018-01-09) in V18 Jan 2, 2019
cryptocode
cryptocode approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@cryptocode cryptocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably do away with recursive_mutex's, but that's a different patch.

@rkeene rkeene merged commit 0235957 into nanocurrency:master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptocode cryptocode cryptocode approved these changes

Assignees

@SergiySW SergiySW

Labels
bug
Projects
No open projects
V18
CP 1 (2018-01-09)
Milestone
V18.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SergiySW @cryptocode @zhyatt @rkeene