Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of contact timestamping drops peers #1536

Merged
merged 2 commits into from Jan 7, 2019

Conversation

Projects
None yet
4 participants
@cryptocode
Copy link
Collaborator

commented Jan 2, 2019

No description provided.

@zhyatt zhyatt added the incomplete label Jan 2, 2019

@zhyatt zhyatt added this to the Research for Future Release milestone Jan 2, 2019

@cryptocode cryptocode added this to CP 3 (2018-01-23) in V18 Jan 3, 2019

@clemahieu

This comment has been minimized.

Copy link
Collaborator

commented Jan 4, 2019

Can we get a test to show last_contact_info being updated correctly?

@cryptocode

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 4, 2019

Yeah, will look into a test

@clemahieu clemahieu merged commit 4dc6682 into nanocurrency:master Jan 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rkeene rkeene requested a review from clemahieu Jan 7, 2019

@rkeene rkeene removed the experiment label Jan 7, 2019

@zhyatt zhyatt removed this from CP 3 (2018-01-23) in V18 Jan 16, 2019

@zhyatt zhyatt modified the milestones: V18.0, V17.1 Jan 16, 2019

rkeene added a commit that referenced this pull request Jan 17, 2019

Lack of contact timestamping drops peers (#1536)
* Lack of contact timestamping drops peers

* Added test to make sure last_contact is updated

@cryptocode cryptocode deleted the cryptocode:fix/dropped-peers branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.