Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set outdated-version status on livenet as well #1538

Merged

Conversation

Projects
4 participants
@cryptocode
Copy link
Collaborator

commented Jan 2, 2019

As a result, the network visitor never deals with messages from outdated peers. There's an outdated-version stat counter though.

@cryptocode cryptocode self-assigned this Jan 2, 2019

@cryptocode cryptocode added this to the V18.0 milestone Jan 2, 2019

@cryptocode cryptocode changed the title Set outdated-version flag on livenet as well Set outdated-version status on livenet as well Jan 2, 2019

@cryptocode cryptocode added this to CP 2 (2018-01-16) in V18 Jan 3, 2019

@zhyatt zhyatt requested a review from wezrule Jan 7, 2019

@wezrule

wezrule approved these changes Jan 9, 2019

Copy link
Collaborator

left a comment

LGTM. The title does suggest this is only for livenet, I assume it's intended that it checks all?

@cryptocode

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 9, 2019

@wezrule the check above that line is a special case for beta (protocol_version_reasonable_min is currently the same as min-version though, not sure if that check will survive)

@argakiig

This comment has been minimized.

Copy link
Collaborator

commented Jan 22, 2019

closing and opening to re-init travis for this PR

@argakiig argakiig closed this Jan 22, 2019

@argakiig argakiig reopened this Jan 22, 2019

@rkeene rkeene removed the experiment label Jan 23, 2019

@rkeene rkeene merged commit 4c33a0f into nanocurrency:master Jan 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:improvement/outdated-version-livenet branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.