Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable clang format where versions disagree #1562

Merged
merged 1 commit into from Jan 9, 2019

Conversation

Projects
3 participants
@cryptocode
Copy link
Collaborator

commented Jan 6, 2019

The current .clang-format file allows for three different results, depending on clang-format version. Proposing this PR to disable formatting where needed, until we have a better solution.

@cryptocode cryptocode self-assigned this Jan 6, 2019

@cryptocode cryptocode added this to the V18.0 milestone Jan 6, 2019

@cryptocode cryptocode added this to CP 1 (2018-01-09) in V18 Jan 6, 2019

@zhyatt zhyatt requested a review from wezrule Jan 7, 2019

@wezrule

wezrule approved these changes Jan 8, 2019

Copy link
Collaborator

left a comment

My clang-format (8.0.0.347735) on Windows puts [[deprecated]] on the same line and I think separate line looks cleaner. There is no clang-format attribute specifier yet (that I could find), so this change is good.

@zhyatt zhyatt merged commit 7d07afe into nanocurrency:master Jan 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:formatting/disable-1 branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.