Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept seed in RPC wallet_create #1567

Merged
merged 4 commits into from Jan 22, 2019

Conversation

Projects
4 participants
@guilhermelawless
Copy link
Contributor

commented Jan 8, 2019

Fixes #1341

Since wallet::change_seed() inserts and returns the first key, it is also included in the response. If seed is not provided, the first account is not generated.

One could argue this is inconsistent behavior, and that doing the same when the seed is not provided would not break anything for users/services, so we could add that too.

@guilhermelawless

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2019

Will clash with #775

@zhyatt

This comment has been minimized.

Copy link
Collaborator

commented Jan 9, 2019

@SergiySW Before we merge #775 do we need to consider the changes in this PR?

@SergiySW

This comment has been minimized.

Copy link
Collaborator

commented Jan 9, 2019

It seems this PR will not affect #775, default change_seed () path was not changed

@SergiySW SergiySW added this to CP 3 (2018-01-23) in V18 Jan 20, 2019

@zhyatt zhyatt added this to the V18.0 milestone Jan 20, 2019

@SergiySW SergiySW merged commit 2e063ec into nanocurrency:master Jan 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@guilhermelawless guilhermelawless deleted the guilhermelawless:wallet_create_seed branch Jan 23, 2019

@rkeene rkeene added the enhancement label Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.