Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checksum table #1579

Merged
merged 2 commits into from Jan 20, 2019

Conversation

Projects
3 participants
@cryptocode
Copy link
Collaborator

commented Jan 12, 2019

Proposing to remove checksum as it isn't used beyond tests, to save some IO in ledger::update_latest and remove some code.

  • delete table in upgrade path (it's just one entry though)

@cryptocode cryptocode self-assigned this Jan 12, 2019

@cryptocode cryptocode added this to the V18.0 milestone Jan 12, 2019

@cryptocode cryptocode added this to CP 2 (2018-01-16) in V18 Jan 12, 2019

@rkeene

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2019

I believe this table can be removed, we are looking at better approaches in #1453.

@zhyatt zhyatt requested a review from wezrule Jan 14, 2019

@clemahieu clemahieu merged commit f74d564 into nanocurrency:master Jan 20, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:cleanup/remove-checksum branch Jan 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.