Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of block table lookups #1587

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
3 participants
@cryptocode
Copy link
Collaborator

commented Jan 14, 2019

Factored out block reading to mirror how block_exists does it. IOW it allows blocks with known types to be looked up directly instead of checking all tables. The only customer right now is block_raw_get.

The lookup order is changed to state (v1, v0), send, receive, open, change. Previously state was looked up last.

@zhyatt zhyatt requested a review from wezrule Jan 22, 2019

@zhyatt zhyatt added this to the V18.0 milestone Jan 22, 2019

@cryptocode cryptocode added this to Nice to have in V18 Jan 24, 2019

@wezrule
Copy link
Collaborator

left a comment

LGTM

@cryptocode cryptocode merged commit 9c3b26b into nanocurrency:master Jan 29, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:block_lookup_reordering branch Jan 29, 2019

@zhyatt zhyatt moved this from Nice to have to CP 3 (2018-01-27) in V18 Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.