Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asan issue (illegal downcast) in test #1595

Merged

Conversation

Projects
3 participants
@cryptocode
Copy link
Collaborator

commented Jan 16, 2019

No description provided.

@cryptocode cryptocode added this to the V18.0 milestone Jan 16, 2019

@cryptocode cryptocode self-assigned this Jan 16, 2019

@cryptocode cryptocode added this to CP 3 (2018-01-23) in V18 Jan 16, 2019

@cryptocode cryptocode requested a review from SergiySW Jan 16, 2019

@SergiySW

This comment has been minimized.

Copy link
Collaborator

commented Jan 17, 2019

So, now it's casting state block to send?

@cryptocode

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 17, 2019

Before this patch, yes, at least according to asan, and that complaint seems correct right?

@SergiySW
Copy link
Collaborator

left a comment

LGTM

@clemahieu clemahieu merged commit 23ef0d3 into nanocurrency:master Jan 20, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:unittest/online_reps-asan-fix branch Jan 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.