Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename announce_votes () to request_confirm () #1598

Merged
merged 2 commits into from Jan 17, 2019

Conversation

Projects
5 participants
@SergiySW
Copy link
Collaborator

commented Jan 16, 2019

announce_loop () --> request_loop ()
announce_interval_ms --> request_interval_ms
as it's no longer used to announce votes

Rename announce_votes () to request_confirm ()
announce_loop () --> request_loop ()
announce_interval_ms --> request_interval_ms
as it's no longer used to announce votes

@SergiySW SergiySW self-assigned this Jan 16, 2019

@zhyatt zhyatt requested review from clemahieu and wezrule Jan 17, 2019

@zhyatt zhyatt added this to the V18.0 milestone Jan 17, 2019

@clemahieu

This comment has been minimized.

Copy link
Collaborator

commented Jan 17, 2019

LGTM, this needed a name change.

@SergiySW SergiySW added this to CP 3 (2018-01-23) in V18 Jan 17, 2019

@rkeene rkeene merged commit 84c64f4 into nanocurrency:master Jan 17, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.