Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json config: fix upgrade of required child nodes #1599

Merged
merged 7 commits into from Jan 17, 2019

Conversation

Projects
2 participants
@cryptocode
Copy link
Collaborator

commented Jan 17, 2019

This fixes a bug introduced by #1416 (upgrade of required nodes)
Would be good to get this merged as master is partially broken wrt json upgrades.

@cryptocode cryptocode self-assigned this Jan 17, 2019

@cryptocode cryptocode added the bug label Jan 17, 2019

@cryptocode cryptocode added this to the V18.0 milestone Jan 17, 2019

@cryptocode cryptocode added this to CP 3 (2018-01-23) in V18 Jan 17, 2019

@cryptocode cryptocode requested a review from wezrule Jan 17, 2019

Show resolved Hide resolved nano/lib/jsonconfig.hpp Outdated
@wezrule

This comment has been minimized.

Copy link
Collaborator

commented Jan 17, 2019

Could any more tests be added to make sure this is fixing what it should and won't be broken in the future?

cryptocode added some commits Jan 17, 2019

@wezrule wezrule merged commit ab3e1fd into nanocurrency:master Jan 17, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.