Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade preconfigured peers in config.json file to use nano url instead of rai #1613

Merged

Conversation

Projects
3 participants
@wezrule
Copy link
Collaborator

commented Jan 22, 2019

This solves #1575 and also 2 other config bugs (jsonconfig::replace_child () not working as expected, and allow_local_peers is not being read from the config file).

nodeconfig.cpp - Add upgraded section from 16 to 17 which updates rai.raiblocks.net -> peering.nano.org and rai-beta.raiblocks.net -> peering-beta.nano.org. To reduce some duplication of the hardcoded strings, I've made some internal linkage variables. Also using emplace_back so that nano::accounts can be created inside the vector directly.
jsonconfig.hpp - There were some warnings generated for unused ex variables so I've now removed them.

Added a new test which checks that both live/beta preconfigured peer urls are successfully changed and one for allow_local_peers.

@wezrule wezrule requested a review from cryptocode Jan 22, 2019

@wezrule wezrule self-assigned this Jan 22, 2019

@cryptocode
Copy link
Collaborator

left a comment

LGTM

@wezrule wezrule merged commit a90bfdc into nanocurrency:master Jan 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:upgrade_preconfigured_peer_config branch Jan 22, 2019

@rkeene rkeene added this to the V18.0 milestone Jan 23, 2019

@wezrule wezrule referenced this pull request Jan 24, 2019

Merged

Support external RPC servers via IPC #1434

7 of 7 tasks complete

@zhyatt zhyatt added this to CP 3 (2018-01-23) in V18 Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.