Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated bulk_pull_blocks #1615

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
2 participants
@wezrule
Copy link
Collaborator

commented Jan 22, 2019

This solves #1585
It removed anything which references bulk_pull_blocks, which was deprecated before and shouldn't be used anymore.

The only thing that is probably worth mentioning is the comment I've added to the removed bulk_pull_blocks enum value in common.hpp to indicate that the message was previously used and deleted, so as not to use it unintentionally, although maybe it's fine.

@wezrule wezrule requested a review from rkeene Jan 22, 2019

@wezrule wezrule self-assigned this Jan 22, 2019

@rkeene rkeene added this to the V18.0 milestone Jan 22, 2019

@rkeene

rkeene approved these changes Jan 22, 2019

Copy link
Contributor

left a comment

Looks good, thanks

@wezrule wezrule merged commit 465147d into nanocurrency:master Jan 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:remove_bulk_pull_blocks branch Jan 22, 2019

@zhyatt zhyatt added this to CP 3 (2018-01-23) in V18 Jan 25, 2019

@wezrule wezrule referenced this pull request Jan 30, 2019

Closed

Remove bulk_pull_blocks #1585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.