Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set permissions to config.json file after creating #1621

Merged

Conversation

Projects
2 participants
@wezrule
Copy link
Collaborator

commented Jan 22, 2019

This solves #1617
When these open functions are called after creating the file they only have read permissions on Windows. This was determined after calling boost::filesystem::status (path_a).permissions (). The solution appears to be to call nano::set_secure_perm_file after the file is created. I've also tidied it up a little. Tested on Windows & Mac

@wezrule wezrule added the bug label Jan 22, 2019

@wezrule wezrule self-assigned this Jan 22, 2019

@wezrule wezrule requested a review from argakiig Jan 22, 2019

@wezrule wezrule merged commit 0757cc9 into nanocurrency:master Jan 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:windows_config_json_not_populated branch Jan 23, 2019

@wezrule wezrule added this to the V18.0 milestone Jan 23, 2019

@zhyatt zhyatt added this to CP 3 (2018-01-23) in V18 Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.