Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rpc.wallet_create_seed test #1628

Merged
merged 2 commits into from Jan 25, 2019

Conversation

Projects
3 participants
@SergiySW
Copy link
Collaborator

commented Jan 24, 2019

Test failing occasionally only with Windows core_test.exe build. Wasn't able to reprocude failures on Linux machine.

system.wallet (0) returning nodes[0]->wallets.items.begin ()->second while wallets.items is unordered_map. According to http://www.cplusplus.com/reference/unordered_map/unordered_map/begin/ an unordered_map object makes no guarantees on which specific element is considered its first element. In test there are 2 wallets in unordered_map: 1st default, 2nd created with RPC.

@SergiySW SergiySW added this to the V18.0 milestone Jan 24, 2019

@SergiySW SergiySW self-assigned this Jan 24, 2019

@SergiySW SergiySW requested a review from cryptocode Jan 24, 2019

@SergiySW SergiySW added this to CP 3 (2018-01-23) in V18 Jan 24, 2019

system::wallet (index) should be used with wallets count == 1 only
Other wallets count can cause tests failures

@argakiig argakiig merged commit 2d7c6bf into nanocurrency:master Jan 25, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.