Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter outdated_version errors from logging #1649

Merged

Conversation

Projects
2 participants
@cryptocode
Copy link
Collaborator

commented Jan 27, 2019

@wezrule noticed outdated_version sometimes causes a large amount of log entries. No reason to log this, it's expected and there's a stat for it.

@cryptocode cryptocode added this to the V18.0 milestone Jan 27, 2019

@cryptocode cryptocode self-assigned this Jan 27, 2019

@cryptocode cryptocode requested a review from wezrule Jan 27, 2019

@cryptocode cryptocode added this to During RC in V18 Jan 27, 2019

@wezrule
Copy link
Collaborator

left a comment

The unwanted entries in the log file are no longer output so LGTM

@cryptocode cryptocode merged commit 135e5d6 into nanocurrency:master Jan 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zhyatt zhyatt moved this from RC2 to CP 3/RC 1 (2018-02-01) in V18 Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.