Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race conditions reported by TSAN #1650

Merged

Conversation

Projects
2 participants
@cryptocode
Copy link
Collaborator

commented Jan 27, 2019

@wezrule Wanna see if this fixes the TSAN traces you noticed during bootstrap? Should also fix a shutdown race.

@cryptocode cryptocode added the bug label Jan 27, 2019

@cryptocode cryptocode added this to the V18.0 milestone Jan 27, 2019

@cryptocode cryptocode self-assigned this Jan 27, 2019

@cryptocode cryptocode requested a review from wezrule Jan 27, 2019

@cryptocode cryptocode added this to During RC in V18 Jan 27, 2019

@wezrule

This comment has been minimized.

Copy link
Collaborator

commented Jan 28, 2019

I still get some TSAN errors, but as discussed it makes sense to not do io on a closed socket anyway. I can have a look at this later as my system seems to reproduce it a bit easier.

@cryptocode cryptocode merged commit 16cb89a into nanocurrency:master Jan 29, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:tsan/fix-races-socket-and-on-flag branch Jan 29, 2019

@zhyatt zhyatt moved this from RC2 to CP 3/RC 1 (2018-02-01) in V18 Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.