Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Gtest to submodule #1661

Merged
merged 5 commits into from Mar 14, 2019

Conversation

@argakiig
Copy link
Collaborator

commented Jan 29, 2019

@argakiig argakiig self-assigned this Jan 29, 2019

@argakiig argakiig requested a review from SergiySW Jan 29, 2019

@argakiig argakiig added this to the V19.0 milestone Jan 29, 2019

@SergiySW

This comment has been minimized.

Copy link
Collaborator

commented Jan 29, 2019

Builds failing right now, I guess some Cmake & include headers paths changes required

@argakiig

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 29, 2019

yeah looks like my cmake cache still had the path, lemme see what i can do to fix it

@argakiig argakiig added this to CP1 in V19 Feb 15, 2019

@SergiySW
Copy link
Collaborator

left a comment

LGTM

@argakiig argakiig force-pushed the argakiig:submodule/gtest branch from d74dd04 to 0443fb4 Mar 14, 2019

@argakiig argakiig requested a review from SergiySW Mar 14, 2019

@SergiySW SergiySW requested a review from cryptocode Mar 14, 2019

@cryptocode
Copy link
Collaborator

left a comment

LGTM, nice to see that force_nano_test_network is retained so we don't have to recompile for testnet to run tests.

@argakiig argakiig merged commit 74e091c into nanocurrency:master Mar 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@argakiig argakiig deleted the argakiig:submodule/gtest branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.