Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the HTTP OPTIONS verb for RPC #1667

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
2 participants
@argakiig
Copy link
Collaborator

commented Jan 30, 2019

Useful for preflighting requests when using CORS.
rebase of #422 before i messed up the push :/

Support the HTTP OPTIONS verb for RPC
Useful for preflighting requests when using CORS.

@argakiig argakiig added this to the V18.0 milestone Jan 30, 2019

@argakiig argakiig self-assigned this Jan 30, 2019

@argakiig argakiig requested a review from cryptocode Jan 30, 2019

@argakiig argakiig added this to CP 2 (2018-01-16) in V18 Jan 30, 2019

@argakiig argakiig moved this from CP 2 (2018-01-16) to During RC in V18 Jan 30, 2019

@cryptocode
Copy link
Collaborator

left a comment

A curl preflight request responds with:

< HTTP/1.1 200 OK
< Allow: POST, OPTIONS
< Content-Type: application/json
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Methods: POST, OPTIONS
< Access-Control-Allow-Headers: Accept, Accept-Language, Content-Language, Content-Type
< Connection: close
< Content-Length: 0

which looks reasonable

@argakiig argakiig merged commit 82734f2 into nanocurrency:master Jan 31, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zhyatt zhyatt moved this from RC2 to CP 3/RC 1 (2018-02-01) in V18 Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.