Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if block processor is full in bulk push server #1668

Merged

Conversation

4 participants
@cryptocode
Copy link
Collaborator

commented Jan 30, 2019

Unclear if not checking block_processor.full is intentional here, so putting it up for discussion. The wallet also doesn't call full(), but Serg felt that's correct there (e.g. receive_action)

@cryptocode cryptocode added this to the V19.0 milestone Jan 30, 2019

@argakiig argakiig assigned argakiig and cryptocode and unassigned argakiig Feb 2, 2019

@argakiig argakiig added the experiment label Feb 2, 2019

@cryptocode cryptocode added this to CP1 in V19 Feb 15, 2019

@cryptocode cryptocode requested a review from SergiySW Feb 21, 2019

@SergiySW
Copy link
Collaborator

left a comment

It makes sense to prevent bulk push ddos

@cryptocode cryptocode closed this Feb 21, 2019

@cryptocode cryptocode reopened this Feb 21, 2019

@cryptocode cryptocode merged commit 78d636c into nanocurrency:master Feb 21, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.