Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FindBoost.Cmake module to support up to boost 1.70.0 #1676

Merged
merged 2 commits into from Feb 1, 2019

Conversation

Projects
4 participants
@argakiig
Copy link
Collaborator

commented Feb 1, 2019

closes #1597

@argakiig argakiig added this to the V18.0 milestone Feb 1, 2019

@argakiig argakiig self-assigned this Feb 1, 2019

@argakiig argakiig requested review from wezrule and cryptocode Feb 1, 2019

Revert "Remove hardcoded FindBoost.cmake and instead rely on local de…
…fault"

This reverts commit 08c576a.
Also updated FindBoost.Cmake from Kitware/CMake@266808c to handle up to Boost 1.77.0 for ubuntu 16.04 cmake 3.5 compatibility
@SergiySW

This comment has been minimized.

Copy link
Collaborator

commented Feb 1, 2019

Wasn't it designed for old Cmake versions with obsolete FindBoost.cmake ? I.e. Ubuntu/Debian/CenOS not updating default cmake to latest versions, just including bugfixes for included version

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Feb 1, 2019

Approved based on it working on my systems, could have the issues Serg mentions.

@argakiig

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 1, 2019

Initially i was going to remove the hardcoded FindBoost, but that broke compatibility with old default cmake versions, so instead I updated the FindBoost.cmake to be the latest available rather than the one capped at 1.66.0

@argakiig argakiig changed the title Remove hardcoded FindBoost.cmake and instead rely on local default Update FindBoost.Cmake module to support up to boost 1.70.0 Feb 1, 2019

@wezrule

wezrule approved these changes Feb 1, 2019

@argakiig argakiig merged commit 7455552 into nanocurrency:master Feb 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

argakiig added a commit that referenced this pull request Feb 1, 2019

@argakiig argakiig added this to CP 3 (2018-01-27) in V18 Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.