Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve votes cache usage #1678

Merged
merged 5 commits into from Feb 1, 2019

Conversation

Projects
3 participants
@SergiySW
Copy link
Collaborator

commented Feb 1, 2019

Search block in cache before disk search
Improving i/o for representative nodes

@SergiySW SergiySW added this to the V18.0 milestone Feb 1, 2019

@SergiySW SergiySW self-assigned this Feb 1, 2019

@SergiySW SergiySW requested review from wezrule and cryptocode Feb 1, 2019

@SergiySW SergiySW added this to During RC in V18 Feb 1, 2019

@cryptocode
Copy link
Collaborator

left a comment

LGTM. I was wondering if it would be beneficial to add a votes_cache::remove_all (which would take a rollback list), to lock only once instead of lock/unlock in the remove loop. But that keeps the lock longer... so I think this is right.

@wezrule

wezrule approved these changes Feb 1, 2019

@SergiySW SergiySW merged commit f716f82 into nanocurrency:master Feb 1, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

argakiig added a commit that referenced this pull request Feb 1, 2019

@zhyatt zhyatt moved this from RC2 to CP 3/RC 1 (2018-02-01) in V18 Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.