Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipc: Handle rpc actions doing async ops #1708

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
4 participants
@cryptocode
Copy link
Collaborator

commented Feb 7, 2019

Thanks to dotcom for finding this

@cryptocode cryptocode added the bug label Feb 7, 2019

@cryptocode cryptocode added this to the V18.0 milestone Feb 7, 2019

@cryptocode cryptocode self-assigned this Feb 7, 2019

@cryptocode cryptocode requested a review from argakiig Feb 7, 2019

@cryptocode cryptocode added this to During RC in V18 Feb 7, 2019

@cryptocode cryptocode requested a review from wezrule Feb 7, 2019

@wezrule

wezrule approved these changes Feb 7, 2019

Copy link
Collaborator

left a comment

LGTM

@guilhermelawless

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2019

send is fixed 👍

@cryptocode

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 8, 2019

@guilhermelawless Thanks for checking, much appreciated!

@cryptocode cryptocode merged commit 690403a into nanocurrency:master Feb 8, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:ipc/fix-async branch Feb 8, 2019

argakiig added a commit that referenced this pull request Feb 18, 2019

@zhyatt zhyatt moved this from RC2 to RC3 in V18 Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.