Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--diagnostics CLI option to check & update config.json file #1733

Merged

Conversation

3 participants
@wezrule
Copy link
Collaborator

commented Feb 16, 2019

The --diagnostics CLI option currently outputs wallet.ldb, node.ldb and the log folder. This is because it creates an inactive node and in this process it generates these files if they don't exist. @icarusglider would like a way to create the config.json file without having to start the daemon and then shut it down immediately. A new option was suggested but deemed unnecessary; so the --diagnostics option has been hijacked. However it also checks the validity of the config.json file so it is not as unrelated as originally thought.

The daemon_config class as well as related ipc/rpc config class have been separated from their source files. Not only does it help with #1112 but the cli.cpp file is used by both nano_node & nano_wallet which now needs access to the daemon_config class which is currently lumped with the nano_node executable, so it was a way to separate the dependencies for source files which only cared about config options.

--diagonistics now creates config.json file
Formatting

See if this fixes the nano_wallet failure

Actually add it...

Separate config files

Formatting

Formatting

@wezrule wezrule self-assigned this Feb 16, 2019

@wezrule wezrule added this to the V19.0 milestone Feb 16, 2019

@wezrule wezrule changed the title --diagnostics to check & update config.json file --diagnostics CLI option to check & update config.json file Feb 16, 2019

@wezrule wezrule requested a review from cryptocode Feb 16, 2019

@cryptocode
Copy link
Collaborator

left a comment

LGTM. A separate --config_create option has been discussed, but that can be done separately.

@wezrule wezrule added this to CP1 in V19 Feb 19, 2019

@wezrule wezrule merged commit b78941a into nanocurrency:master Feb 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:create_config_modify_diagonistics_cli branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.