Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the sideband open block start at a height of 1 #1737

Merged
merged 3 commits into from Feb 17, 2019

Conversation

Projects
3 participants
@wezrule
Copy link
Collaborator

commented Feb 17, 2019

Account block count + sideband block height now match at the head
Sideband/confirmation height now start at 0 to indicate that they are uninitialized

@wezrule wezrule added this to the V18.0 milestone Feb 17, 2019

@wezrule wezrule self-assigned this Feb 17, 2019

@wezrule wezrule requested review from clemahieu and SergiySW Feb 17, 2019

Show resolved Hide resolved nano/node/lmdb.cpp Outdated

@wezrule wezrule merged commit c079de3 into nanocurrency:master Feb 17, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@wezrule wezrule deleted the wezrule:start_open_block_height_1 branch Feb 17, 2019

SergiySW added a commit to SergiySW/raiblocks that referenced this pull request Feb 17, 2019

SergiySW added a commit that referenced this pull request Feb 17, 2019

Update CLI --debug_validate_blocks to validate sideband data (#1735)
* Update CLI --debug_validate_blocks to validate sideband data

* Update for #1737 changes

* Remove unnecessary timestamp numeric limit check

@SergiySW SergiySW added this to During RC in V18 Feb 17, 2019

argakiig added a commit that referenced this pull request Feb 18, 2019

Make the sideband open block start at a height of 1 (#1737)
* Open block now starts at height 1 for sideband data

* Remove incorrectly modified clang-format file

* Change start height of local variable to be 1 instead of addition later

argakiig added a commit that referenced this pull request Feb 18, 2019

Update CLI --debug_validate_blocks to validate sideband data (#1735)
* Update CLI --debug_validate_blocks to validate sideband data

* Update for #1737 changes

* Remove unnecessary timestamp numeric limit check

@zhyatt zhyatt moved this from RC2 to RC3 in V18 Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.