Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implicitly converted argument #1751

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented Feb 19, 2019

This was something I spotted when looking at this area of code. false here is being implicitly converted to an int 0 which is passed in to a function which already has a default parameter unsigned chunk_size = 0. So I'm just removing it.

@wezrule wezrule added this to the V19.0 milestone Feb 19, 2019

@wezrule wezrule self-assigned this Feb 19, 2019

@wezrule wezrule requested a review from cryptocode Feb 19, 2019

@wezrule wezrule changed the title Remove unnecessary argument Remove implicitly converted argument Feb 19, 2019

@wezrule wezrule added this to CP1 in V19 Feb 19, 2019

@wezrule wezrule merged commit 0355c19 into nanocurrency:master Feb 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:remove_implicit_conversion_argument_import_bits branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.