Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused member functions in secure library and various other cleanups #1764

Merged
merged 3 commits into from Feb 22, 2019

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented Feb 22, 2019

Various members functions are not used in secure/common.hpp/cpp and versioning.hpp/cpp and have been removed
Made a few default constructors = default and moved initialization to be in-class instead.
all size() comparisons with 0 now use empty() i.e replace var.size() > 0 with !var.empty()
Some other things as I found them (const member functions, use .front (), use reference instead of copy etc..)

wezrule added some commits Feb 20, 2019

@wezrule wezrule added this to the V19.0 milestone Feb 22, 2019

@wezrule wezrule self-assigned this Feb 22, 2019

@wezrule wezrule requested a review from argakiig Feb 22, 2019

@wezrule wezrule added this to CP1 in V19 Feb 22, 2019

@wezrule wezrule merged commit ebdcdad into nanocurrency:master Feb 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:cleanup branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.