Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve block_exists table lookup order #1765

Conversation

2 participants
@cryptocode
Copy link
Collaborator

commented Feb 22, 2019

Same as was done for block_raw_get, i.e order table lookups according to match probability.

@cryptocode cryptocode added this to the V19.0 milestone Feb 22, 2019

@cryptocode cryptocode self-assigned this Feb 22, 2019

@cryptocode cryptocode requested a review from wezrule Feb 22, 2019

@cryptocode cryptocode added this to CP1 in V19 Feb 22, 2019

@@ -1709,13 +1709,14 @@ bool nano::mdb_store::block_exists (nano::transaction const & transaction_a, nan

bool nano::mdb_store::block_exists (nano::transaction const & tx_a, nano::block_hash const & hash_a)
{
// Table lookups are ordered by match probability

This comment has been minimized.

Copy link
@wezrule

wezrule Feb 22, 2019

Collaborator

should it be "to match"?

@cryptocode cryptocode merged commit 1b1b7f2 into nanocurrency:master Feb 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cryptocode cryptocode deleted the cryptocode:improvement/block_exists-lookup_ordering branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.