Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a warning if TSAN/ASAN used together as CMake options #1767

Merged
merged 3 commits into from Feb 25, 2019

Conversation

2 participants
@wezrule
Copy link
Collaborator

commented Feb 22, 2019

Currently we can set both TSAN=ON and ASAN=ON as options to CMake. Without paying attention to build flags it's not obvious that only ASAN is used. This is because currently they are mutually exclusive in both gcc and clang. I have made it display a warning now if they are. If ASAN and ASAN_INT are both used, ASAN_INT is prioritised.

@wezrule wezrule added the sanitizers label Feb 22, 2019

@wezrule wezrule added this to the V19.0 milestone Feb 22, 2019

@wezrule wezrule self-assigned this Feb 22, 2019

@wezrule wezrule requested a review from argakiig Feb 22, 2019

@wezrule wezrule merged commit cda9345 into nanocurrency:master Feb 25, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wezrule wezrule deleted the wezrule:mutally_exclusive_sanitizers branch Feb 25, 2019

@zhyatt zhyatt added this to CP1 (2019-03-13) in V19 Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.