Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate `payments_` RPC calls #1773

Merged
merged 1 commit into from Feb 25, 2019

Conversation

@SergiySW
Copy link
Collaborator

commented Feb 24, 2019

@SergiySW SergiySW added this to the V19.0 milestone Feb 24, 2019

@SergiySW SergiySW self-assigned this Feb 24, 2019

@SergiySW SergiySW requested review from argakiig and cryptocode Feb 24, 2019

@SergiySW SergiySW added this to CP0 in V19 Feb 24, 2019

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Feb 24, 2019

An alternative I was thinking about is to add deprecation in Wiki docs only and then in version + 1 require a flag ("allow_deprecated": "true") to allow the deprecated action (the response would otherwise be something like "error": "deprecated"). In version + 2 or 3, the action is removed. The flag could be either an RPC param or a config option.

This would give users ample warning while still being able to opt-in for a version or two, and then there's a way to actually remove actions and be confident that users know it'll happen.

@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 24, 2019

I guess we can add it now in rpc response & wiki, in v20 require ("allow_deprecated": "true") & remove ~ v22

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Feb 24, 2019

@SergiySW sounds like a good plan

@SergiySW SergiySW merged commit 91c03c6 into nanocurrency:master Feb 25, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.