Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support difficulty for OpenCL generate_work () #1775

Merged
merged 6 commits into from Feb 26, 2019

Conversation

2 participants
@SergiySW
Copy link
Collaborator

commented Feb 24, 2019

@SergiySW SergiySW added this to the V19.0 milestone Feb 24, 2019

@SergiySW SergiySW self-assigned this Feb 24, 2019

@SergiySW SergiySW requested a review from wezrule Feb 24, 2019

@SergiySW SergiySW added this to CP0 in V19 Feb 24, 2019

@wezrule
Copy link
Collaborator

left a comment

The test is currently disabled, it would be good to get some working opencl tests to check stuff like this is behaving correctly.

@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 25, 2019

Test requires OpenCL device on test machine, most servers don't have it

@wezrule

This comment has been minimized.

Copy link
Collaborator

commented Feb 25, 2019

true but we can add a check to see if opencl is supported, and if not then the test logic can be ignored for those systems. Our dev systems can then still run the tests locally

@SergiySW SergiySW force-pushed the SergiySW:opencl_difficulty branch from 2ed2429 to 605d5b1 Feb 25, 2019

@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 25, 2019

@wezrule test updated, if you have opencl system

SergiySW added some commits Feb 25, 2019

@SergiySW SergiySW merged commit d2edf57 into nanocurrency:master Feb 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.