Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the error code overloads for socket shutdown/close #1786

Merged
merged 6 commits into from Mar 26, 2019

Conversation

@wezrule
Copy link
Collaborator

commented Feb 25, 2019

Changing to use the error code version of shutdown as we are just ignoring the exception anyway and if turning on "catch all exceptions" with MSVC this gets frequently caught. As a side effect I noticed that we are using the throwing version of socket::close as well, this has been changed to just log the error rather than (potentially) crashing the node as the underlying file descriptor (as per the asio function comment) is closed.

@wezrule wezrule added this to the V19.0 milestone Feb 25, 2019

@wezrule wezrule self-assigned this Feb 25, 2019

@wezrule wezrule requested a review from cryptocode Feb 25, 2019

@zhyatt zhyatt requested a review from clemahieu Feb 25, 2019

wezrule added some commits Feb 27, 2019

@zhyatt zhyatt added this to CP1 in V19 Feb 28, 2019

Show resolved Hide resolved nano/node/bootstrap.cpp Outdated

@wezrule wezrule merged commit d66c7c9 into nanocurrency:master Mar 26, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@wezrule wezrule deleted the wezrule:error_code_overload_socket_close branch Mar 26, 2019

guilhermelawless added a commit to guilhermelawless/nano-node that referenced this pull request Apr 15, 2019

Use the error code overloads for socket shutdown/close (nanocurrency#…
…1786)

* Use the error code overloads for socket shutdown/close

* Remove comparison for error code

* Use new time limited logger

* Add bootstrap stat socket close errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.