Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Use the error code overloads for socket shutdown/close #1786
Changing to use the error code version of shutdown as we are just ignoring the exception anyway and if turning on "catch all exceptions" with MSVC this gets frequently caught. As a side effect I noticed that we are using the throwing version of socket::close as well, this has been changed to just log the error rather than (potentially) crashing the node as the underlying file descriptor (as per the asio function comment) is closed.