Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TCP server timeout #1790

Merged
merged 12 commits into from Mar 13, 2019

Conversation

@SergiySW
Copy link
Collaborator

commented Feb 26, 2019

Make timeouts configurable

Add TCP server timeout
Make timeouts configurable

@SergiySW SergiySW added this to the V19.0 milestone Feb 26, 2019

@SergiySW SergiySW self-assigned this Feb 26, 2019

@SergiySW SergiySW requested review from clemahieu and cryptocode Feb 26, 2019

@cryptocode

This comment has been minimized.

Copy link
Collaborator

commented Feb 26, 2019

I don't think start() needs a param after this change, that function should just set cutoff to now() (maybe rename from cutoff to start_time or something?)

@SergiySW

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 26, 2019

@cryptocode good point!

@SergiySW SergiySW requested review from cryptocode and wezrule Feb 26, 2019

@zhyatt zhyatt added this to CP1 in V19 Feb 28, 2019

Show resolved Hide resolved nano/core_test/network.cpp Outdated
Show resolved Hide resolved nano/core_test/network.cpp
Show resolved Hide resolved nano/node/nodeconfig.cpp
Show resolved Hide resolved nano/node/bootstrap.cpp
Show resolved Hide resolved nano/node/bootstrap.cpp Outdated
@wezrule

wezrule approved these changes Mar 1, 2019

@SergiySW SergiySW merged commit b50df3e into nanocurrency:master Mar 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

SergiySW added a commit that referenced this pull request Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.