Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valgrind fixes & suppressions #1814

Merged
merged 8 commits into from Mar 15, 2019

Conversation

@SergiySW
Copy link
Collaborator

commented Mar 9, 2019

  • Fix detelcted by Valgrind compute_reps () issue
  • Improve logging headers
  • Minor tests improvements & fixes
  • Valgrind suppression file (usage valgrind --suppressions=valgrind.supp)
    Note: to run Valgrind reduce map_size in lmdb.hpp from 128GB to to several MB

@SergiySW SergiySW added the sanitizers label Mar 9, 2019

@SergiySW SergiySW added this to the V19.0 milestone Mar 9, 2019

@SergiySW SergiySW self-assigned this Mar 9, 2019

@SergiySW SergiySW requested review from wezrule and cryptocode Mar 9, 2019

@SergiySW SergiySW added this to CP1 (2019-03-13) in V19 Mar 9, 2019

@cryptocode
Copy link
Collaborator

left a comment

LGTM

Show resolved Hide resolved nano/node/logging.hpp Outdated

@SergiySW SergiySW merged commit 6e1cfda into nanocurrency:master Mar 15, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SergiySW SergiySW referenced this pull request Mar 15, 2019

Closed

Issues detect by valgrind #654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.